Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: unit test for mutable vector #2768

Merged
merged 1 commit into from
Nov 20, 2023

Conversation

QuenKar
Copy link
Contributor

@QuenKar QuenKar commented Nov 17, 2023

I hereby agree to the terms of the GreptimeDB CLA

What's changed and what's your intention?

add test for vector data_type() which implement in MutableVector trait

Checklist

  • I have written the necessary rustdoc comments.
  • I have added the necessary unit tests and integration tests.

Refer to a related PR or issue link (optional)

Closes #2754

Copy link

codecov bot commented Nov 17, 2023

Codecov Report

Merging #2768 (a2768a6) into develop (ae27fbc) will decrease coverage by 0.39%.
Report is 8 commits behind head on develop.
The diff coverage is 100.00%.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #2768      +/-   ##
===========================================
- Coverage    85.36%   84.98%   -0.39%     
===========================================
  Files          774      774              
  Lines       125796   126030     +234     
===========================================
- Hits        107391   107105     -286     
- Misses       18405    18925     +520     

@evenyag evenyag enabled auto-merge November 20, 2023 03:38
Copy link
Contributor

@killme2008 killme2008 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@evenyag evenyag added this pull request to the merge queue Nov 20, 2023
Merged via the queue into GreptimeTeam:develop with commit 01867ad Nov 20, 2023
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add a test for MutableVector datatype method
3 participants